Changeset 1517 in ProjectBuilder for devel/pb-modules/lib/ProjectBuilder/Distribution.pm

Timestamp:

May 10, 2012, 6:07:28 PM (12 years ago)

Author:

Bruno Cornec

Message:

r4765@localhost: bruno | 2012-05-10 17:08:00 +0200

• pb.conf: centos-5.6 moved python-libs into a separate package. List it or otherwise we can't run yum. Fix the mirror servers for centos-4,5 to just get the latest, and add mirror servers for 6.
• pb.conf.pod: document addrepo, looked here and didn't find it, accidentally found it in code before adding it myself. Fix pod glitch at the end (missing =over/=back)
• Distribution.pm: move the code to apply ftp_proxy/http_proxy from the conf files to a sub function since it's now needed in two places. Log the proxy and verify that everything we tried to install succeeded since yum will silently tolerate failing to install things, but rpmbuild will complain about missing dependencies. Tolerate an error from testing install of an rpm in pb_distro_setuprepo_gen.
• Env.pm: Give an example of multi-line filters and an example of a transform.
• VE.pm: If the verpmtype isn't defined, error out cleanly. Otherwise we're just going to fail later with lots of noisy output.

File:

• devel/pb-modules/lib/ProjectBuilder/Distribution.pm (modified) (6 diffs)

devel/pb-modules/lib/ProjectBuilder/Distribution.pm

@@ -290 +290 @@
 }
 
+# Internal function
+
+sub pb_apply_conf_proxy ($) {
+my ($pbos) = @_;
+
+my $ftp_proxy = pb_distro_get_param($pbos,pb_conf_get_if("ftp_proxy"));
+my $http_proxy = pb_distro_get_param($pbos,pb_conf_get_if("http_proxy"));
+
+# We do not overwrite shell settings
+$ENV{ftp_proxy} ||= $ftp_proxy;
+$ENV{http_proxy} ||= $http_proxy;
+}
+
 =item B<pb_distro_installdeps>
 
@@ -304 +317 @@
 my $deps = shift || undef;
 
-my $ftp_proxy = pb_distro_get_param($pbos,pb_conf_get_if("ftp_proxy"));
-my $http_proxy = pb_distro_get_param($pbos,pb_conf_get_if("http_proxy"));
-
-# We do not overwrite shell settings
-$ENV{ftp_proxy} ||= $ftp_proxy;
-$ENV{http_proxy} ||= $http_proxy;
-
+pb_apply_conf_proxy($pbos);
 # Protection
 return if (not defined $pbos->{'install'});
@@ -316 +323 @@
 # Get dependencies in the build file if not forced
 $deps = pb_distro_getdeps($f,$pbos) if (not defined $deps);
+pb_log(1, "ftp_proxy=$ENV{ftp_proxy} http_proxy=$ENV{http_proxy}\n");
 pb_log(2,"deps: $deps\n");
 return if ((not defined $deps) || ($deps =~ /^\s*$/));
@@ -326 +334 @@
     pb_system($cmd, "Re-trying installing dependencies ($cmd)");
 }
+# Check that all deps have been installed correctly
+$deps = pb_distro_getdeps($f, $pbos);
+die "Some dependencies did not install ($deps)" if ((defined $deps) && ($deps =~ /\S/));
 }
 
@@ -520 +531 @@
 return if ($param eq "");
 
+pb_apply_conf_proxy($pbos);
+
 # Loop on the list of additional repo
 foreach my $i (split(/,/,$param)) {
@@ -538 +551 @@
             my $pn = $bn;
             $pn =~ s/\.rpm//;
-            if (pb_system("rpm -q --quiet $pn","","quiet") != 0) {
+            if (pb_system("rpm -q --quiet $pn","","quiet",1) != 0) {
                 pb_system("sudo rpm -Uvh $ENV{'PBTMP'}/$bn","Adding package to setup repository");
             }