Changeset 1553 in ProjectBuilder for devel/pb/lib

Timestamp:

May 21, 2012, 3:06:00 AM (12 years ago)

Author:

Bruno Cornec

Message:

• pb: log when we start and finish the build, that's an important state. Add missing setting of all_ok to false that kept us from properly stopping on errors. Fix typos in comments (coma => comma). Greatly simplify pb_get_distros function by using split and join. Also remove whitespace since multi-line conf file support will cause that to be added. (Eric Anderson)
• Filter.pm: use new pb_pbos_to_keylist function to generate the list of basenames we want, and use a loop rather than lots of separate statements. Simplifies and makes more powerful this function. Also now guaranteed to maintain consistency with key lookups in the hash maps. (Eric Anderson)
• rename pb_pbos_to_keylist to pb_distro_to_keylist and make it public (Bruno Cornec)

File:

• devel/pb/lib/ProjectBuilder/Filter.pm (modified) (1 diff)

devel/pb/lib/ProjectBuilder/Filter.pm

@@ -73 +73 @@
 # Global filter files first, then package specific
 my @file_basenames = ('all');
-@file_basenames = reverse pb_pbos_to_keylist($pbos, 'all') if (defined $pbos);
+@file_basenames = reverse pb_distro_to_keylist($pbos, 'all') if (defined $pbos);
 # Build list of all filter files
 foreach my $dir ("$ENV{PBROOTDIR}/pbfilter", "$ENV{PBROOTDIR}/$pbpkg/pbfilter") {