Changeset 1556 in ProjectBuilder for devel/pb

Timestamp:

May 21, 2012, 3:46:31 AM (12 years ago)

Author:

Bruno Cornec

Message:

pb: Use new pbgpgcheck option to control whether we enable gpgcheck in the repo script. Problem is that signing failure is tolerated, so the rpms can be unsigned, but gpgcheck is on by default. Preserve those semantics by default, but allow for control. (Eric Anderson)

• pbgpgcheck is optional and default to 1 (Bruno Cornec)

File:

• devel/pb/bin/pb (modified) (2 diffs)

devel/pb/bin/pb

@@ -2025 +2025 @@
         if ($pbos->{'type'} eq "rpm") {
             my $pbsha = pb_distro_get_param($pbos,pb_conf_get("ossha"));
+            my $gpgcheck = pb_conf_get_if("pbgpgcheck");
+            my $pbgpgcheck;
+            $pbgpgcheck = $gpgcheck->{$ENV{PBPROJ}} if (defined $gpgcheck);
+            # By default force GPG check in repo even if we support signature of packages to fail. This is a best practice
+            $pbgpgcheck = 1 if (not defined $pbgpgcheck);
             # Also make a pbscript to generate yum/urpmi bases
             print PBS << "EOF";
@@ -2037 +2042 @@
 baseurl=$pbrepo->{$ENV{'PBPROJ'}}/$repodir
 enabled=1
-gpgcheck=1
+gpgcheck=$pbgpgcheck
 gpgkey=$pbrepo->{$ENV{'PBPROJ'}}/$repodir/$ENV{'PBPROJ'}.pubkey
 EOT