Changeset 1558


Ignore:
Timestamp:
May 21, 2012, 3:56:09 AM (7 years ago)
Author:
bruno
Message:
  • pb: [BUGFIX] added code assumed it had Parallel::ForkManager? package. (Eric Anderson)
  • Fix more typos on comma (Bruno Cornec)
Location:
devel
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • devel/pb-modules/lib/ProjectBuilder/Base.pm

    r1528 r1558  
    435435
    436436This function checks that the commands needed for the subsystem are indeed present.
    437 The required commands are passed as a coma separated string as first parameter.
    438 The optional commands are passed as a coma separated string as second parameter.
     437The required commands are passed as a comma separated string as first parameter.
     438The optional commands are passed as a comma separated string as second parameter.
    439439
    440440=cut
     
    450450$opt2 = $opt->{$appname} if (defined $opt and defined $appname);
    451451
    452 # cmds is a string of coma separated commands
     452# cmds is a string of comma separated commands
    453453if (defined $req2) {
    454454    foreach my $file (split(/,/,$req2)) {
     
    457457}
    458458
    459 # opts is a string of coma separated commands
     459# opts is a string of comma separated commands
    460460if (defined $opt2) {
    461461    foreach my $file (split(/,/,$opt2)) {
  • devel/pb/bin/pb

    r1557 r1558  
    1717# in their respective section
    1818use Getopt::Long qw(:config auto_abbrev no_ignore_case);
    19 use Carp 'cluck';
     19use Carp qw/confess cluck/;
    2020use Data::Dumper;
    2121use English;
     
    10901090            my $pm = new Parallel::ForkManager($pbparallel) if (defined $pbparallel);
    10911091            $pm->run_on_finish(sub { my ($pid, $code, $id, $signal, $dump) = @_;
    1092                                     $all_ok = 0 unless (($code == 0) && ($signal == 0) && ($dump == 0)); });
     1092                                    $all_ok = 0 unless (($code == 0) && ($signal == 0) && ($dump == 0)); }) if (defined $pbparallel);
    10931093
    10941094            pb_log(0,"Preparing delivery ...\n");
     
    43174317    }
    43184318    my $debsigncmd = pb_check_req("debsign",1);
    4319     pb_system("$debsigncmd -m\'$ENV{'PBPACKAGER'}\' $changes","Signing DEB packages",undef,1) if ($changes ne "");
     4319    pb_system("$debsigncmd -m\'$ENV{'PBPACKAGER'}\' $changes","Signing DEB packages",undef,1) if (($changes ne "") && (defined $debsigncmd));
    43204320} else {
    43214321    pb_log(0,"I don't know yet how to sign packages for type $pbos->{'type'}.\nPlease give feedback to dev team\n");
Note: See TracChangeset for help on using the changeset viewer.