Changeset 2434 in ProjectBuilder for devel/pb-modules/lib/ProjectBuilder/Conf.pm

Timestamp:

Sep 6, 2019, 3:35:27 PM (5 years ago)

Author:

Bruno Cornec

Message:

force explicit analysis of boolean and when using cluck

File:

• devel/pb-modules/lib/ProjectBuilder/Conf.pm (modified) (3 diffs)

devel/pb-modules/lib/ProjectBuilder/Conf.pm

@@ -185 +185 @@
 # Read the content of the config file and cache it in the %h hash then available for queries
 if ($PBCONFVER < 1) {
-    open(CONF,$cf) || cluck "Unable to open $cf" && return($lh);
+    open(CONF,$cf) || (cluck "Unable to open $cf" && return($lh));
     # This is the original conf file format for versions up to 0.14
     while(<CONF>) {
@@ -337 +337 @@
 confess "No configuration file defined to write into !" if (not defined $conffile);
 confess "No hash defined to read from !" if (not defined $h);
-open(CONF,"> $conffile") || cluck "Unable to write into $conffile" && return;
+open(CONF,"> $conffile") || (cluck "Unable to write into $conffile" && return);
 
 if ($PBCONFVER < 1) {
@@ -553 +553 @@
 my $dest = shift;
 
-open(ORIG,$orig) || cluck "Unable to open $orig" && return;
+open(ORIG,$orig) || (cluck "Unable to open $orig" && return);
 confess "Will not erase existing $dest while transforming $orig" if (-f $dest);
-open(DEST,"> $dest") || cluck "Unable to write into $dest" && close(ORIG) && return;
+open(DEST,"> $dest") || (cluck "Unable to write into $dest" && close(ORIG) && return);
 print DEST "---\n";
 my $pbconfverbkp = $PBCONFVER;