Changeset 1109 in ProjectBuilder for devel/pb-modules/lib/ProjectBuilder/Log.pm

Timestamp:

Nov 17, 2010, 12:40:28 PM (13 years ago)

Author:

Bruno Cornec

Message:

r4041@localhost: bruno | 2010-11-17 11:40:41 +0100

• Adds new configuration parameters (oschkcmd, oschkopt) to externalize package checking command
• Adds new configuration parameters (pbinstalltype, pbpkg) to start allowing installation of pb in VM/VE with packages or files (this last is only needed by upstream)
• Remove dependency on Mail::Sendmail to where it's really needed (part of Log, not used yet, and annouce). In particular this removes one non std dep for VE/VM build.

File:

• devel/pb-modules/lib/ProjectBuilder/Log.pm (modified) (3 diffs)

devel/pb-modules/lib/ProjectBuilder/Log.pm

@@ -5 +5 @@
 
 use strict;
-use Mail::Sendmail;
 use ProjectBuilder::Base;
 use ProjectBuilder::Log::Item;
@@ -227 +226 @@
 # mails the summary to $to
 sub mailSummary {
+    require Mail::Sendmail;
     my $self = shift;
     my $to = shift || "";
@@ -239 +239 @@
         Message => $self->summary()
     );
-    sendmail(%mail) or return $Mail::Sendmail::error;
+    if (! sendmail(%mail)) { 
+        if (defined $Mail::Sendmail::error) {
+            return $Mail::Sendmail::error;
+        } else {
+            return "Unkown error";
+        }
+    }
     pb_log(0,"Mail send to ". $to ."\n");
 }