Ticket #87 (closed defect: fixed)

Opened 3 years ago

Last modified 3 years ago

pbsrc content should be put in SOURCES directory when building RPMs

Reported by: ndoualot Owned by: bruno
Priority: major Milestone: 0.11.1
Component: pb Version: 0.10.1
Keywords: Cc:

Description

Right now, the pbsrc content is in the SPECS folder

rpmbuild fails to found those referenced files:

error: Bad file: /home/ndo/lighttpd/build/SOURCES/logo-hpintel.jpg.all: No such file or directory
error: Bad file: /home/ndo/lighttpd/build/SOURCES/lighttpd.sh.rhel: No such file or directory
error: Bad file: /home/ndo/lighttpd/build/SOURCES/lighttpd.run.rhel: No such file or directory
error: Bad file: /home/ndo/lighttpd/build/SOURCES/lighttpd.conf.all: No such file or directory
error: Bad file: /home/ndo/lighttpd/build/SOURCES/index.html.tmpl.all: No such file or directory


RPM build errors:
    Bad file: /home/ndo/lighttpd/build/SOURCES/logo-hpintel.jpg.all: No such file or directory
    Bad file: /home/ndo/lighttpd/build/SOURCES/lighttpd.sh.rhel: No such file or directory
    Bad file: /home/ndo/lighttpd/build/SOURCES/lighttpd.run.rhel: No such file or directory
    Bad file: /home/ndo/lighttpd/build/SOURCES/lighttpd.conf.all: No such file or directory
    Bad file: /home/ndo/lighttpd/build/SOURCES/index.html.tmpl.all: No such file or directory

Change History

comment:1 follow-up: ↓ 2 Changed 3 years ago by bruno

  • Status changed from new to assigned
  • Milestone set to 0.10.2

In fact when using pbsrc, the spec file is modified to generate Source1, Source2, ... entries in order to point to these additional sources.

What pb could do automatically, is move at build time all the files found under the pbsrc dir under pbconf to SOURCES for rpm build. Wold that be ok for you ?

Remains to see what to do for other types of build...

comment:2 in reply to: ↑ 1 ; follow-up: ↓ 3 Changed 3 years ago by ndoualot

Replying to bruno:

In fact when using pbsrc, the spec file is modified to generate Source1, Source2, ... entries in order to point to these additional sources.

This works fine after the r1218 commit, but thinks doesn't work well for the source rpm.

What pb could do automatically, is move at build time all the files found under the pbsrc dir under pbconf to SOURCES for rpm build. Wold that be ok for you ?

This what I meant with this bug report.

I don't know if it is a task for ProjectBuilder? or for the packager to put the files under SOURCES for the src.rpm creation.

Remains to see what to do for other types of build...

comment:3 in reply to: ↑ 2 Changed 3 years ago by bruno

Replying to ndoualot:

Replying to bruno:

What pb could do automatically, is move at build time all the files found under the pbsrc dir under pbconf to SOURCES for rpm build. Wold that be ok for you ?

This what I meant with this bug report.

Ok, we're on the same page then :-)

I don't know if it is a task for ProjectBuilder? or for the packager to put the files under SOURCES for the src.rpm creation.

Well, as pb does the .spec modification, it seems important to me that it also put the sources at the right place, which is not difficult as it know where they are and where to put them. Will work on a patch for that.

Remains to see what to do for other types of build...

Still true.

comment:4 Changed 3 years ago by bruno

  • Fixed in rev [1219]. This requires to update pb in the VM|RM|VE in order to work correctly (with setupvm|rm|ve).

As you have the correct infra in place, please test it and report again your findings.

comment:5 follow-up: ↓ 6 Changed 3 years ago by bruno

You need rev [1220]

comment:6 in reply to: ↑ 5 Changed 3 years ago by ndoualot

  • Status changed from assigned to closed
  • Resolution set to fixed

Replying to bruno:

You need rev [1220]

Works fine (tested with rev [1221])

Note: See TracTickets for help on using tickets.